tehp / OpenPoGoWeb

Web View for OpenPoGoBot
77 stars 58 forks source link

Make it possible to disable Pokemon Go map style from config #143

Open BobbyWibowo opened 7 years ago

BobbyWibowo commented 7 years ago

This will disable Pokemon Go map style only when explicitly instructed to

RolfKoenders commented 7 years ago

Cool! This is only on initial load? I tried to make it a setting you can just flip on in the settings but i have an issue.. When the map gets re-drawn it seems all the items and the trainer are gone (These need to be saved somewhere in a var i assume, since new items will appear on the map) You can checkout my code here

BobbyWibowo commented 7 years ago

@RolfKoenders Yeah, it's only on initial load. Just a simple configurable setting since someone requested for it. As for more advanced stuff, I had actually made a switch style setting in my personal build: https://github.com/BobbyWibowo/OpenPoGoWeb/commit/e4d1d449205de0d54cac0d035e87f4746b5cb99e#commitcomment-18463528.

Basically, you shouldn't redraw the map. But instead, just pass the new style setting to the existing map. The map object has a function called setOptions() which allows you to pass new options. So I simply did setOptions(style: [le' new style]), and it would change the styling without breaking anything else.

MaxLeiter commented 7 years ago

status on this?

BobbyWibowo commented 7 years ago

@MaxLeiter Should work just fine as it is imo

Reaver01 commented 7 years ago

conflicts

knowncitizen commented 7 years ago

I've been using this for a week and a half. Aside from the merge conflicts, it works great.

BobbyWibowo commented 7 years ago

@Reaver01 I'm not sure if I did it right, but I guess conflicts are fixed now.

Reaver01 commented 7 years ago

👍

Approved with PullApprove