search

tehp / OpenPoGoWeb

Web View for OpenPoGoBot
77 stars 58 forks source link

Refactor main.js, use Socket.io for grabbing updates from the bot #159

Closed wchill closed 7 years ago

wchill commented 7 years ago

This is a revamped version of #106 that has been rebased against master.

The goal is to reimplement grabbing data from the bot to display in the web interface using Socket.io while also refactoring main.js to make it easier to make changes to data objects as well as the interface itself.

All data objects are implemented in ES6 classes. Properties of data objects should not be referenced directly, and the explicit getter functions should be used instead for readability/maintainability purposes.

In addition, files have been retabbed to 4 spaces per tabstop to bring them in line with the main bot repo which also uses 4 spaces.

Relies on https://github.com/OpenPoGo/OpenPoGoBot/pull/155 for event functionality to work.

Don't merge yet, this is not ready.

wchill commented 7 years ago

Closing because we are rewriting web instead.