tehp / OpenPoGoWeb

Web View for OpenPoGoBot
77 stars 58 forks source link

Change some icons more clearer #44

Closed qfdk closed 8 years ago

qfdk commented 8 years ago

I put the original file "PNG" in my site Download here qq20160721-0 2x

jtdroste commented 8 years ago

Interesting! Can you give a estimate of the average filesize of one of these new images? I'm on terribly slow hotel wifi, so I can't download it right now.

meyer9 commented 8 years ago

I'd like to see this implemented.

Alcazer commented 8 years ago

in main.js line 281

https://github.com/OpenPoGo/OpenPoGoWeb/blob/master/main.js#L281 icon: 'image/pokemon/' + pad_with_zeroes(data.pokemon_id, 3) + imageExt, change icon: {url:'image/pokemon/' + pad_with_zeroes(data.pokemon_id, 3) + imageExt, scaledSize: new google.maps.Size(70, 70)},

and

in main.js line 299

https://github.com/OpenPoGo/OpenPoGoWeb/blob/master/main.js#L299 user_data[users[user_index]].catchables[data.spawnpoint_id].setIcon('image/pokemon/' + pad_with_zeroes(data.pokemon_id, 3) + imageExt); change user_data[users[user_index]].catchables[data.spawnpoint_id].setIcon({url:'image/pokemon/' + pad_with_zeroes(data.pokemon_id, 3) + imageExt, scaledSize: new google.maps.Size(70, 70)});

and

in main.css line 50

https://github.com/OpenPoGo/OpenPoGoWeb/blob/master/main.css#L50 .png_img { width: 96px; height: auto; } change .png_img { width: 96px; height: 96px; }

last

change imgs folder name to pokemon then dont forget add zero like (1.png -> 001.png)

or change all pad_with_zeroes(data.pokemon_id, 3) + imageExt to data.pokemon_id + '.png'

Reaver01 commented 8 years ago

I will just batch rename the files

Reaver01 commented 8 years ago

No need to change Js for images.

Alcazer commented 8 years ago

new images are big, this js commands scale new images

old images sizes 96x96 new images sizes 120x120 (some 126x120, 144x120, 148x120, 150x120, 158x117)

or resize all images

RedSparr0w commented 8 years ago

Yeah the new images will just need to be scaled a bit, as they appear quite large on the map.

i dont think we should put

.png_img {
    width: 96px;
    height: 96px;
}

as some of the images are not square (such as Golbat) and will be distorted

edit: unless we batch process them to all be square? edit 2: Only the following are not 120x120

144
131
006
018
022
042
142
146
103
RedSparr0w commented 8 years ago

Think this can be closed now.