tehp / OpenPoGoWeb

Web View for OpenPoGoBot
77 stars 58 forks source link

Update new web view #9

Closed sniok closed 8 years ago

sniok commented 8 years ago

image Update new web view with:

glennvgastel commented 8 years ago

Looks better than what I had cooked up, I'll add my sorting logic to your code when it's accepted.

meyer9 commented 8 years ago

:-1: Clicking the button again should close the modal.

Rejected with PullApprove

sniok commented 8 years ago

@jmeyer2k It was behaving wierd with multiple bots so I replaced it with close button on content window. Previous behaviour can be returned in following commits once I or someone else figure out how to do it

Reaver01 commented 8 years ago

I will look into modifying this to work as intended

sniok commented 8 years ago

Opening window on button and closing on big X is a normal behavior and should not be treated like bug.

glennvgastel commented 8 years ago

Using the X to close works for now, so I'd say approve this so we can improve it :)

meyer9 commented 8 years ago

:+1: gets my approval. last approval should be reaver.

Approved with PullApprove

Reaver01 commented 8 years ago

It apparently didn't take the commits I just made

MaxLeiter commented 8 years ago

You have to push them to his fork (as in, make a PR) @Reaver01