search

tehp / OpenPoGoWeb

Web View for OpenPoGoBot
77 stars 58 forks source link

fixing the candy count #98

Closed fierysolid closed 8 years ago

fierysolid commented 8 years ago

The API response appears to have changed. Changing the web code to match the response.

douglascamata commented 8 years ago

@Reaver01 please check this, candy count is broken on current master branch with updated pgoapi.

Reaver01 commented 8 years ago

👍

fierysolid commented 8 years ago

We ever going to merge this?

Reaver01 commented 8 years ago

:+1: I hope so

Reaver01 commented 8 years ago

@OpenPoGo/admin

MaxLeiter commented 8 years ago

This code is impossible to review with such a large diff... Please fix your commits so it's readable (i.e. only change code you need to change)

xorinzor commented 8 years ago

It seems most of the diff is just because of a change in the spaces/tabs of the code for readability

MaxLeiter commented 8 years ago

Then that belongs in it's own PR (we -really- need to discuss a set style at some point).

BobbyWibowo commented 8 years ago

The fact that it also includes WebSocket removal should make it belong to another PR imo

xorinzor commented 8 years ago

Sounds fair to me

fierysolid commented 8 years ago

Shit forgot I had a PR on this branch. The socket stuff isn't supposed to be in it

theebanka commented 8 years ago

So was this ever merged? Or is there some way to fix this relatively easily?

fierysolid commented 8 years ago

Change Pokemon_family to candy

On Jul 29, 2016, at 6:53 PM, theebanka notifications@github.com wrote:

So was this ever merged? Or is there some way to fix this relatively easily?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

theebanka commented 8 years ago

Thank you!