Closed YingchaoJiStone closed 1 day ago
Amazing job @YingchaoJiStone. I have read all the code and checked all the tests manually using postman and everything works. However, I must mention that the newman thing does not work. But that is not related to this issue and will be done with setting up the Github Actions. Great job. The code was well commented and readable.
Amazing job @YingchaoJiStone. I have read all the code and checked all the tests manually using postman and everything works. However, I must mention that the newman thing does not work. But that is not related to this issue and will be done with setting up the Github Actions. Great job. The code was well commented and readable.
Thanks for your review! The problem you have with newman is a connection error? If it is that is because the current test requires starting the server and then running the test in another terminal, it cannot be started and tested with npm run test. In the next stage we can configure with wait-on to fix it.
Description
Please include a summary of the feature being added or updated. Explain why this feature is necessary and what problem it solves.
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify the feature. Provide instructions so others can replicate these tests. Include any relevant details like the test environment, test cases, and scripts.
Checklist
Impacted Areas in the Project
Please specify which areas of the project this feature might affect.
Additional Information
Add any additional context or concerns that may be relevant to this feature, including dependencies, potential risks, or rollout plan.
I added /decoded/ and /converters/ in Gitignoor. It is to avoid uploading the decoding code and files in my own computer to GitHub, which is not necessary for the project.
Reviewer’s Guide:
Please ensure: