#2 improve the username sign up validation

[bonapartbon]

I fixed and tested the issue. It works fine now.

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @tehseen01 on Vercel.

@tehseen01 first needs to authorize it.

[bonapartbon]

@tehseen01 you can see it here. Thanks

[bonapartbon]

Hi, thanks for your contribution. I have a few suggestions to improve the username sign up validation:

• You can use a more descriptive error message for the regex pattern, such as “Username can only contain lowercase letters, numbers, hyphens, dots and underscores”.
• You can use Yup.string().required(“Username is required”) instead of Yup.string().required(“*This field is required”), to make it clear which field is missing.
• Here is how the code would look like after applying these suggestions:

    .matches(/^[a-z0-9-._]+$/, "Username can only contain lowercase letters, numbers and  . _ -")
    .min(2)
    .max(25)
    .required("Username is required"),```

I made those changes. Thanks!

[bonapartbon]

Thanks for contributing

Sure, I'll try to contribute more on your project.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
instagram-clone	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2023 7:26am