Open teilhard1976 opened 6 years ago
Overall: -learning a new language is like, well, learning a new language... it just takes practice! I'm sure you'll get great at it -good job on reorganizing your repo. apparently using the desktop version is much easier to do certain things like deleting folders (in which the only way I know how using the web version is by deleting all the files inside) so maybe give it a try! -homework file (rmd, no rendered md) was organized and each section was clear and easy to find -code was clear and concise -reflections included
Overall Suggestions: -I didn't find a rendered md file so had to "guess" the output a bit.. -since there was no output, maybe include a conclusion on what the result for each question was and add a comment or description on what you were trying to do with your code -your ReadMe isn't an md file so your syntax probably did not display the way you wanted
Suggestions on Specific Sections: Factor management -all the tasks completed here and the code seems to be good but again, try to add some comments
File I/O -explore some differences these different formats can cause
Visualization design -again, since no plot was rendered, maybe talk about what you changed and how it affected the new plot in comparison to the old one
Writing figures to file -try adding a link to the saved file to see if it worked
Peer Reviewed by Kevin Zhu
Factor management (drop & reorder): Yes File I/O (data): Partial (writes files, does not read) Visualization design: Yes File I/O (write figure): Partial (writes files, does not read) Organized GitHub: No (see comments) Bonus (more forcats, eg relevel): No Reflection: Yes
Comments:
Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.
Comments:
Over all all is good.
@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho