teivah / TIBreview

Quality code review for TIBCO BusinessWorks 6
GNU General Public License v3.0
9 stars 6 forks source link

Next Functionality #6

Open Tantino opened 7 years ago

Tantino commented 7 years ago

Hi Friend, This issue is to resume the next functionality or to brainstorm about we would like to include in the project. you're in agreement?

Thanks and regards.

teivah commented 7 years ago

Hi Tantino,

One of the main thing I wanted to improve is the way to create Java tasks. So far the parsing of a TIBCO process was really basic (I was only retrieving the metadata of the process actually). I improved it in the develop branch to have a clear model of a TIBCO process from an XML file.

To do it I merge the code from the official plugin made by TIBCO. I believe that's a good add for our solution.

Based on this, we can think about more complex rules (not only based on the XPath engine).

Perhaps one good addition as well would be the capability to analyze a process from a plugin (integrated within Studio) not only in command line.

What do you think on these points?

Tantino commented 7 years ago

Hi Teivah,

I agree that the plugin for Studio is a good idea.

About: Based on this, we can think about more complex rules (not only based on the XPath engine). Could you tell me a example? The process file is always a XML and going forward with XPATH expresion processing should be enough.

In this point To do it I merge the code from the official plugin made by TIBCO. I believe that's a good add for our solution. You need to merge your code (Tibreview) to (TIBCo maven plugin) or the opposite ( tibco maven plugin to TIBreview)

Could you create a maven plugin / gradle /other option standard for the project? In tibco bw5 I created a plugin/script that wrote documentation in different format txt/wiki/html What do you think about these points?;)

Thanks and regards.

teivah commented 7 years ago

>Could you tell me a example? The process file is always a XML and going forward with XPATH expresion processing should be enough.

Sure, let's take a concrete example there. What about the capability to check for potential cycles (e.g. Process A -> Process B -> Process A). In that case perhaps I'd like to raise a warning saying that a cycle has been found. In this case, an XPath rule might not be enough. It is complex enough to rather do it in Java.

>You need to merge your code (Tibreview) to (TIBCo maven plugin) or the opposite ( tibco maven plugin to TIBreview) Their code into ours ;) I did it in the develop branch.

In tibco bw5 I created a plugin/script that wrote documentation in different format txt/wiki/html What do you think about these points?;) Definitely, that would be a good idea. Yet I have no experience in such plugins. If you want to propose something, please :)

teivah commented 7 years ago

Also, I was thinking that the Sonar integration was easier but actually it seems it is not the case. I thought we could give to Sonar a PMD file directly (just like in Jenkins) but it seems that's not the case, it would require to create a specific Sonar plugin.

Tantino commented 7 years ago

how this? Please find atachment. TIBReview.pptx

The maven plugin is not problem. I create this funcionality only execute the project with the parameter necesary. is this correct?

Sorry by my English. thanks and regards.

teivah commented 7 years ago

Hi Tantino,

What's this exactly (in the pptx)? A plugin you created? If yes that's exactly the kind of thing we need!!

Tantino commented 7 years ago

hi @teivah Yes this code is in local PC. ;.) (I would like to sell for many money) it is a beta version and java class caos;) The problem ofr the plugin is not possible to create sonar dinamic rules. I need to generate class by rule . one example:  For each row of the file tibrule.xml we need to generate Rule Sonar class. It is a lot of work.

I am creating a multi maven proyect we will have two funcionality in the same proyect TIBReview-console and TIBReview-maven

What do you think about these points?;)

thanks and regards.

teivah commented 7 years ago

Mmh I see. Perhaps the model with a tibrules.xml file was correct only with an integration with the Jenkins PMD file. With Sonar it is not the best one.

I agree, this seems a good idea having a TIBreview-console and a TIBreview-maven.

Perhaps in TIBreview-maven we could include as you proposed functionalities to export configuration but also to automate code creation for example. If our project organization makes sense, we can easily extend the current functionality.

Tantino commented 7 years ago

Hi @teivah you show this.

TIBReview-maven:analyze Goal which touches a timestamp file. Available parameters: inputPath -s: input path, if -i was set to project you must reference a BW6 project ex: C:/tibco/workspace/myProjec inputType -i: input type, use project to analyze a whole project, process to analyze a single process, resource to analyze a single resource ex: project outputDirectory Location of the file. Required: Yes outputType -o: output type (CSV or PMD file) properties -c: config.properties file ex: config.properties targetType -t: target path ex: C:/output tibrules -r: tibrules.xml file ex: tibrules.xml

TIBreview-Parent

mvn install mvn TIBReview-maven:help mvn TIBReview-maven:help -Ddetail=true -Dgoal=analyze mvn TIBReview-maven:analyze

The state of the proyect is beta this is not execute tibteview-console . This proyect is only the structure.

Happy end-weekend. Thanks and regrads.

Tantino commented 7 years ago

Hi @teivah I have created the plugin TIBReview-maven. PFA [TIBReview-parent.rar](https://drive.google.com/open?id=0B1IsFT6chZfDdVNfME00b2QzcDg) For my new plugin I need your engine components.(this engine finds the file in the folder. Is this right?) Could you separate this engine in a TIBreview-Core proyect? Thanks and regards.

srujanpulathota commented 5 years ago

Hi @teivah,

Firstly, thanks for this project , its very useful. would like to know if we can integrate this in sonar, if so could you please give a brief on that.

Thanks Srujan