search

tejacques / crosstab

A utility library for cross-tab communication using localStorage.
Apache License 2.0
366 stars 58 forks source link

0.3.0 #50

Open tejacques opened 9 years ago

mcwhittemore commented 9 years ago

What is the upgrade path for this? From our chats before I figured this was making some breaking changes. If so, I think it would be wise to bump the major version so NPM doesn't just break people's apps.

tejacques commented 9 years ago

No breaking changes in 0.3.0. There is different behavior, but it is backwards compatible. Specifically, there are some new API calls and some extensions to the existing API, as well as a change in the way crosstab.supported works. If it is not supported, the will act as though it is master, and will not communicate via localStorage. The latter is a large change in behavior, but will not break any existing code.

Most of the work is done, but it needs a lot of testing before releasing. I'm not sure yet if I want to try and get crosstab working on mobile with iframes for 0.3.0 or for 1.0.0.

The next steps to 1.0.0 are really solidifying the API, figuring out the IE11/Edge situation, and iframes on mobile, as well as documentation.

brandonros commented 8 years ago

Is this safe to test?

tejacques commented 8 years ago

It should be safe to test, yes, but to be honest development has effectively stalled due to inherent issues with Windows 10 and localStorage on IE/Edge. There is an OS dependency in handling localStorage, and the way it happens changed from Windows 7 to 10 (8 is possibly affected as well).

I can't engineer around it using localStorage, and using alternatives, like IndexedDB are simply too slow, or cannot be relied upon.

It will still work the vast majority of the time, but it feels really bad to know something just doesn't work for a modern browser.

brandonros commented 8 years ago

Chrome on Windows 10 should be fine though, no?

What changed from 7/8 -> 10 in IE/Edge?

tejacques commented 8 years ago

If you want the full reading, this has a good breakdown: https://github.com/bemson/subetha-bridge/issues/1

If you want the short version: https://connect.microsoft.com/IE/feedback/details/2141793/unique-localstorage-items-dropped-between-windows (that is closed, but not fixed, it simply got moved and still remains an issue)