search

tejado / pgoapi

Pokemon Go API lib
Other
1.4k stars 445 forks source link

Migrate rpc_api._make_rpc() to pyCurl for increased performance. #128

Open karololszacki opened 8 years ago

karololszacki commented 8 years ago

Because many projects are using your pgoapi and make lots of requests using the API, I thought about optimising it (minimising req time) and found a project which is utilising CURL instead of the requests lib. They actually use ParallelCurl but I guess just a regular pyCurl would be a nice improvement. The project I am talking about.

According to this answer pyCurl would be twice as fast as requests lib, and could serve each of the requests significantly faster.

tejado commented 8 years ago

Hi, yes, I'm planning to build the network stuff as an abstracted class. So then it will be easy to integrate.

tejado commented 8 years ago

I guess this is obsolete with the new server throttling?

karololszacki commented 8 years ago

I am not entirely sure. I believe PycURL puts slightly less load on our end (it's using a native lib - libcurl - written in C), and as people start running their projects with multiple accounts to compensate for the throttling, it can still be beneficial for us.

Lower priority - sure, but I think it still should be done someday.