tejado / pgoapi

Pokemon Go API lib
Other
1.4k stars 447 forks source link

close_fds=true leads to protoc errors on Windows #213

Open BarrinFromKjeld opened 7 years ago

BarrinFromKjeld commented 7 years ago

Hi guys,

As per documentation of subprocess, close_fds must not be true when redirecting stdin, stdout and stderr for Windows: "Note that on Windows, you cannot set close_fds to true and also redirect the standard handles by setting stdin, stdout or stderr." Source: https://docs.python.org/2/library/subprocess.html

I ran into the obscure error "Couldn't find protoc in your environment OR other issue..." in RpcApi.decode_raw

Kind regards, Barrin