search

tejank10 / AlphaGo.jl

AlphaGo Zero implementation using Flux.jl
https://fluxml.ai/experiments/go
Other
73 stars 14 forks source link

Global board variables #1

Open MikeInnes opened 6 years ago

MikeInnes commented 6 years ago

https://github.com/tejank10/AlphaGo.jl/blob/c2b809c65431f54110dabd042724a364ed03f14e/src/board.jl#L21-L26

It would be better to initialise these with arguments somehow, either when we first construct the Go board, or with some kind of GoRules struct that defines these parameters.

tejank10 commented 6 years ago

How about we initialize them in src/go.jl?

tejank10 commented 6 years ago

This has been fixed in alphazero branch