FranklinSamboni commented 4 years ago

Description

This branch fix the bug DropDown toggle #17, The way followed was add a tap gesture to the current top view that allow us to identify when an user tap on any position on the top view. Besides, I added a UIGestureRecognizerDelegate to close de DropDown even if two gestures are recognized simultaneously (when user focus a UITextField or another type of gesture)

Fixes #17

Type of change

[✓] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe on what device it is tested:

Device: iPhone 11 Pro Max simulator OS: 14.1 Xcode: 12.0.1

Checklist:

[✓] My code follows the style guidelines of this project
[✓] I have performed a self-review of my own code
[✓] I have commented my code, particularly in hard-to-understand areas
[✓] I have made corresponding changes to the documentation
[✓] My changes generate no new warnings

Reviewers:

@tejuamirthi

tejuamirthi commented 4 years ago

Hey @FranklinSamboni you might need to take a pull from main and resolve conflicts! Please update your branch

tejuamirthi commented 4 years ago

@FranklinSamboni Can you provide a recording of the same? I need to see the selected row to be updated! Thanks

FranklinSamboni commented 4 years ago

@tejuamirthi, I want apologize for the delay, I didn't see your comments. I did the necessary changes, now you can test again.

FranklinSamboni commented 4 years ago

@tejuamirthi Thanks :D. 👍

tejuamirthi / CustomDropDown

Dropdown toggle #18

Description

Type of change

How Has This Been Tested?

Checklist:

Reviewers: