Double PR for #102 and #101!

tribbloid commented 1 year ago

This is the new PR that:

fix #102 by simplifying type formatting
fix #101 by introducing P:splain:Vtype-reduction option

Please see integration test ground truth for effect

tribbloid commented 1 year ago

@tek request for review.

tek commented 1 year ago

I'm a bit too out of practice to be able to contribute anything substantial here 🙂

tribbloid commented 1 year ago

wait .. there is a minor fix I need to push in to avoid showing redundant type reduction (where before/after are identical)

I also prefer to release a hotfix version 1.0.3 just for #100 , this PR introduces a lot of behavioural changes and should be fore 1.1.0

github-actions[bot] commented 1 year ago

Test Report (2.13.7)

78 tests +20 78 :heavy_check_mark: +23 15s :stopwatch: ±0s 13 suites +  3   0 :zzz: -   3 13 files +  3   0 :x: ±  0

Results for commit d43a7228. ± Comparison against base commit f96cf9d0.

This pull request removes 21 and adds 41 tests. Note that renamed tests count towards both.

``` splain.builtin.BasicSpec ‑ refined splain.builtin.TreeSpec ‑ compactTree splain.builtin.TreeSpec ‑ verboseTree splain.builtin.TruncRefinedSpec ‑ truncrefined splain.plugin.DivergingSpec ‑ ... with max depth - circular splain.plugin.DivergingSpec ‑ ... without verbose-tree - diverging-compact splain.plugin.DivergingSpec ‑ .... with max depth - circular splain.plugin.DivergingSpec ‑ circular splain.plugin.DivergingSpec ‑ circular-recoverable splain.plugin.DivergingSpec ‑ diverging … ``` ``` splain.builtin.BasicSpec ‑ refined1 splain.builtin.BasicSpec ‑ refined2 splain.builtin.BasicXSource3Spec ‑ auxType splain.builtin.BasicXSource3Spec ‑ bounds splain.builtin.BasicXSource3Spec ‑ bynameParam splain.builtin.BasicXSource3Spec ‑ chain splain.builtin.BasicXSource3Spec ‑ deeplyNestedHole splain.builtin.BasicXSource3Spec ‑ disambiguateQualified splain.builtin.BasicXSource3Spec ‑ foundReq splain.builtin.BasicXSource3Spec ‑ longAnnotationMessage … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

Test Report (2.13.8)

78 tests +20 78 :heavy_check_mark: +23 12s :stopwatch: -2s 13 suites +  3   0 :zzz: -   3 13 files +  3   0 :x: ±  0

Results for commit d43a7228. ± Comparison against base commit f96cf9d0.

This pull request removes 21 and adds 41 tests. Note that renamed tests count towards both.

``` splain.builtin.BasicSpec ‑ refined splain.builtin.TreeSpec ‑ compactTree splain.builtin.TreeSpec ‑ verboseTree splain.builtin.TruncRefinedSpec ‑ truncrefined splain.plugin.DivergingSpec ‑ ... with max depth - circular splain.plugin.DivergingSpec ‑ ... without verbose-tree - diverging-compact splain.plugin.DivergingSpec ‑ .... with max depth - circular splain.plugin.DivergingSpec ‑ circular splain.plugin.DivergingSpec ‑ circular-recoverable splain.plugin.DivergingSpec ‑ diverging … ``` ``` splain.builtin.BasicSpec ‑ refined1 splain.builtin.BasicSpec ‑ refined2 splain.builtin.BasicXSource3Spec ‑ auxType splain.builtin.BasicXSource3Spec ‑ bounds splain.builtin.BasicXSource3Spec ‑ bynameParam splain.builtin.BasicXSource3Spec ‑ chain splain.builtin.BasicXSource3Spec ‑ deeplyNestedHole splain.builtin.BasicXSource3Spec ‑ disambiguateQualified splain.builtin.BasicXSource3Spec ‑ foundReq splain.builtin.BasicXSource3Spec ‑ longAnnotationMessage … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

Test Report (2.13.9)

78 tests +20 78 :heavy_check_mark: +23 11s :stopwatch: -6s 13 suites +  3   0 :zzz: -   3 13 files +  3   0 :x: ±  0

Results for commit d43a7228. ± Comparison against base commit f96cf9d0.

This pull request removes 21 and adds 41 tests. Note that renamed tests count towards both.

``` splain.builtin.BasicSpec ‑ refined splain.builtin.TreeSpec ‑ compactTree splain.builtin.TreeSpec ‑ verboseTree splain.builtin.TruncRefinedSpec ‑ truncrefined splain.plugin.DivergingSpec ‑ ... with max depth - circular splain.plugin.DivergingSpec ‑ ... without verbose-tree - diverging-compact splain.plugin.DivergingSpec ‑ .... with max depth - circular splain.plugin.DivergingSpec ‑ circular splain.plugin.DivergingSpec ‑ circular-recoverable splain.plugin.DivergingSpec ‑ diverging … ``` ``` splain.builtin.BasicSpec ‑ refined1 splain.builtin.BasicSpec ‑ refined2 splain.builtin.BasicXSource3Spec ‑ auxType splain.builtin.BasicXSource3Spec ‑ bounds splain.builtin.BasicXSource3Spec ‑ bynameParam splain.builtin.BasicXSource3Spec ‑ chain splain.builtin.BasicXSource3Spec ‑ deeplyNestedHole splain.builtin.BasicXSource3Spec ‑ disambiguateQualified splain.builtin.BasicXSource3Spec ‑ foundReq splain.builtin.BasicXSource3Spec ‑ longAnnotationMessage … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

Test Report (2.13.10)

78 tests +20 78 :heavy_check_mark: +23 14s :stopwatch: -2s 13 suites +  3   0 :zzz: -   3 13 files +  3   0 :x: ±  0

Results for commit d43a7228. ± Comparison against base commit f96cf9d0.

This pull request removes 21 and adds 41 tests. Note that renamed tests count towards both.

``` splain.builtin.BasicSpec ‑ refined splain.builtin.TreeSpec ‑ compactTree splain.builtin.TreeSpec ‑ verboseTree splain.builtin.TruncRefinedSpec ‑ truncrefined splain.plugin.DivergingSpec ‑ ... with max depth - circular splain.plugin.DivergingSpec ‑ ... without verbose-tree - diverging-compact splain.plugin.DivergingSpec ‑ .... with max depth - circular splain.plugin.DivergingSpec ‑ circular splain.plugin.DivergingSpec ‑ circular-recoverable splain.plugin.DivergingSpec ‑ diverging … ``` ``` splain.builtin.BasicSpec ‑ refined1 splain.builtin.BasicSpec ‑ refined2 splain.builtin.BasicXSource3Spec ‑ auxType splain.builtin.BasicXSource3Spec ‑ bounds splain.builtin.BasicXSource3Spec ‑ bynameParam splain.builtin.BasicXSource3Spec ‑ chain splain.builtin.BasicXSource3Spec ‑ deeplyNestedHole splain.builtin.BasicXSource3Spec ‑ disambiguateQualified splain.builtin.BasicXSource3Spec ‑ foundReq splain.builtin.BasicXSource3Spec ‑ longAnnotationMessage … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

Test Report (2.13.11)

78 tests +20 78 :heavy_check_mark: +23 11s :stopwatch: -4s 13 suites +  3   0 :zzz: -   3 13 files +  3   0 :x: ±  0

Results for commit d43a7228. ± Comparison against base commit f96cf9d0.

This pull request removes 21 and adds 41 tests. Note that renamed tests count towards both.

``` splain.builtin.BasicSpec ‑ refined splain.builtin.TreeSpec ‑ compactTree splain.builtin.TreeSpec ‑ verboseTree splain.builtin.TruncRefinedSpec ‑ truncrefined splain.plugin.DivergingSpec ‑ ... with max depth - circular splain.plugin.DivergingSpec ‑ ... without verbose-tree - diverging-compact splain.plugin.DivergingSpec ‑ .... with max depth - circular splain.plugin.DivergingSpec ‑ circular splain.plugin.DivergingSpec ‑ circular-recoverable splain.plugin.DivergingSpec ‑ diverging … ``` ``` splain.builtin.BasicSpec ‑ refined1 splain.builtin.BasicSpec ‑ refined2 splain.builtin.BasicXSource3Spec ‑ auxType splain.builtin.BasicXSource3Spec ‑ bounds splain.builtin.BasicXSource3Spec ‑ bynameParam splain.builtin.BasicXSource3Spec ‑ chain splain.builtin.BasicXSource3Spec ‑ deeplyNestedHole splain.builtin.BasicXSource3Spec ‑ disambiguateQualified splain.builtin.BasicXSource3Spec ‑ foundReq splain.builtin.BasicXSource3Spec ‑ longAnnotationMessage … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

Test Report (2.13.12)

78 tests +20 78 :heavy_check_mark: +23 14s :stopwatch: ±0s 13 suites +  3   0 :zzz: -   3 13 files +  3   0 :x: ±  0

Results for commit d43a7228. ± Comparison against base commit f96cf9d0.

This pull request removes 21 and adds 41 tests. Note that renamed tests count towards both.

``` splain.builtin.BasicSpec ‑ refined splain.builtin.TreeSpec ‑ compactTree splain.builtin.TreeSpec ‑ verboseTree splain.builtin.TruncRefinedSpec ‑ truncrefined splain.plugin.DivergingSpec ‑ ... with max depth - circular splain.plugin.DivergingSpec ‑ ... without verbose-tree - diverging-compact splain.plugin.DivergingSpec ‑ .... with max depth - circular splain.plugin.DivergingSpec ‑ circular splain.plugin.DivergingSpec ‑ circular-recoverable splain.plugin.DivergingSpec ‑ diverging … ``` ``` splain.builtin.BasicSpec ‑ refined1 splain.builtin.BasicSpec ‑ refined2 splain.builtin.BasicXSource3Spec ‑ auxType splain.builtin.BasicXSource3Spec ‑ bounds splain.builtin.BasicXSource3Spec ‑ bynameParam splain.builtin.BasicXSource3Spec ‑ chain splain.builtin.BasicXSource3Spec ‑ deeplyNestedHole splain.builtin.BasicXSource3Spec ‑ disambiguateQualified splain.builtin.BasicXSource3Spec ‑ foundReq splain.builtin.BasicXSource3Spec ‑ longAnnotationMessage … ```

:recycle: This comment has been updated with latest results.

tek / splain