search

tek / splain

better implicit errors for scala
MIT License
370 stars 29 forks source link

Broken on 2.12.4 #13

Closed nafg closed 6 years ago

nafg commented 6 years ago

From a discussion on gitter.im/scala/contributors:

nafg @nafg October 31, 2017 10:14 PM I'm trying to use the tek/splain compiler plugin and it works fine with 2.12.3 but with 2.12.4 I get java.lang.NoClassDefFoundError: scala/reflect/internal/util/Statistics$

Harrison Houghton @hrhino October 31, 2017 10:30 PM I think jvican removed that and redid the statistics infra. tek might need to publish a 2.12.4+ version of the plugin

Jorge @jvican November 2, 2017 4:54 AM @nafg: @hrhino is correct. Statistics are no longer objects, they are in the compiler cake, so that's why you get that classloading issue. The issue here is that compiler plugins are often cross-compiled to the Scala partial version (2.10, 2.11, 2.12), when they should instead be cross-compiled to the full scala version (2.12.1, 2.12.2, 2.12.3, 2.12.4). The reason why this is the only reasonable way to do it is because the compiler API does not have any bincompat guarantees.

tek commented 6 years ago

I've released packages for patch versions, please verify!

nafg commented 6 years ago

Looks good, thanks!

On Tue, Nov 7, 2017 at 2:03 PM Torsten Schmits notifications@github.com wrote:

I've released packages for patch versions, please verify!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tek/splain/issues/13#issuecomment-342587341, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGAUMVqltX0jqBxDkhmHy03p5os8QNOks5s0KmTgaJpZM4QQIXJ .