search

tek / splain

better implicit errors for scala
MIT License
370 stars 29 forks source link

Scals 2.13 support #22

Closed jtjeferreira closed 5 years ago

jtjeferreira commented 5 years ago

Hi, thanks for this great plugin! Any change to support scala 2.13.0-M5?

tek commented 5 years ago

thank you! :smile: 0.4.0 is in the process of being published, please report back whether it works for you!

jtjeferreira commented 5 years ago

I tried to do this but was blocked in some non backwards compatible change in the Scala compiler and one test was failing... You have a branch with that code?

tek commented 5 years ago

you tried publishing locally? I meant install it from maven! it's already promoted, so just change your dependency and it should be found. the tests are indeed broken for <2.13 now, I'll need to investigate what changed in order to fix it. But since it was only a minor failure, I've published it anyway.

tek commented 5 years ago

just noticed that I haven't pushed the repo. I guess you meant that you tried to create a PR but failed at the test! in any case, my previous comment still holds :smile:

jtjeferreira commented 5 years ago

Yes I was looking for the code changes :p

tek commented 5 years ago

they're there now :laughing: