tek / splain

better implicit errors for scala
MIT License
370 stars 29 forks source link

file structure of most classes are now compliant with JVM language standard #50

Closed tribbloid closed 3 years ago

tribbloid commented 3 years ago

file structure of most classes are now compliant with JVM language standard:

BTW: are you using any CI service? Have you considered enabling github action that run the test everytime a patch has been submitted?

tek commented 3 years ago

added you as a collaborator, go wild with the github actions!

tek commented 3 years ago

@tribbloid if you want to merge this, go ahead! unless you want to active Actions first.

tribbloid commented 3 years ago

roger roger, sorry I was a bit slacking due to other projects. The actions should be easy tho

tek commented 3 years ago

no pressure, just thought you might be waiting for me to merge it

tribbloid commented 3 years ago

OK I've finally done. The CI is online: https://github.com/tribbloid/splain/runs/2592505496?check_suite_focus=true

Just ping me to approve the merge

tek commented 3 years ago

awesome, go ahead!

did you see that the compiler PR was merged?

tribbloid commented 3 years ago

Yeah, and the ZIO patch, thanks a lot!

There seems to be a problem of my collaborator's permission:

[splain] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain origin refs/heads/#43/tree:#43/tree
remote: Permission to tek/splain.git denied to tribbloid.
fatal: unable to access 'https://github.com/tek/splain/': The requested URL returned error: 403

Can you double check if I'm in the group?

tek commented 3 years ago

the problem is that you haven't accepted the invite! I'll see if I can resend it

tribbloid commented 3 years ago

I see, sorry don't know it expires. Using my permission now ...

https://github.com/tek/splain/actions/runs/847753214

tek commented 3 years ago

yay! :partying_face: