tek / splain

better implicit errors for scala
MIT License
370 stars 29 forks source link

Add 2.12.14 #55

Closed ithinkicancode closed 3 years ago

tek commented 3 years ago

thanks :purple_heart:

tek commented 3 years ago

@tribbloid there seem to be some issues that look like they're related to your latest commit, can you take a look?

tribbloid commented 3 years ago

absolutely. I assume they only manifests on 2.12.14

tek commented 3 years ago

yeah, something in that Statistics object was removed

tribbloid commented 3 years ago

I encounter the same problem in 2.13.6, but 2.13.6+ should use the new architecture (https://github.com/tek/splain/issues/53). So I ignored it.

We will need a new shim layer, this is not caused by my change but I'll make it work

tek commented 3 years ago

great, thanks!

tribbloid commented 3 years ago

BTW @ithinkicancode this one is on us: our CI doesn't have cross-build pipelines yet

But it's better if you run sbt + compile to make sure that it at least compiles