search

tek / splain

better implicit errors for scala
MIT License
370 stars 29 forks source link

project is not clonable on windows #64

Closed unkarjedy closed 2 years ago

unkarjedy commented 2 years ago

Try to check out the project on Windows and get error:

git checkout master
fatal: cannot create directory at 'tests/aux': Invalid argument

This is because aux is a reserved name on windows. The best fix is to rename the folder.

See: https://github.com/git-for-windows/git/issues/2777#issuecomment-752769489 https://www.howtogeek.com/fyi/windows-10-still-wont-let-you-use-these-file-names-reserved-in-1974/ https://github.com/swcarpentry/DEPRECATED-bc/pull/464 https://stackoverflow.com/questions/63727594/github-git-checkout-returns-error-invalid-path-on-windows

tribbloid commented 2 years ago

Wow, didn't see that coming.

Please refrain from submitting PR yet. I'm converting it to be more compliant to the test format in scalac 2.13.6

tribbloid commented 2 years ago

@unkarjedy can you pull the latest master and recompile using gradle? Should be working now

tribbloid commented 2 years ago

Feel free to close it if it works

unkarjedy commented 2 years ago

Looks like it works now)

tribbloid commented 2 years ago

@unkarjedy there seems to be another problem, we always uses "/" as the path splitter, In Windows the convention should be using "\", does this break your compilation or testing?

unkarjedy commented 2 years ago

It compiles fine, without issues.

I can't run tests of this project on my laptop though, so can't say about tests.

we always use "/" as the path splitter

Windows accepts / just fine So as long as you use / to generate paths, no issues should arise. If somewhere in the code you handle paths that come from OS (e.g. list files in some directory) and check for / then issues might arise.