Rachel/landing page - Githubissues

tekgrunt / kokalee

This is the main home for the edge networking project aimed at remote teams or low-budget remote camps (aka. tent style cams).

2 stars 1 forks source link

Rachel/landing page #18

Closed tekgrunt closed 6 years ago

tekgrunt commented 6 years ago

Rachel should probably be making this PR but I am hoping it can just get merged into development and be the platform we are working off of. There is still some work to do on the branch but that can just get peeled off of development. Yes?

rachel-joy commented 6 years ago

Yes! There's more work to do for sure, but that can be done off a new branch once this is merged into development.

Issues I know of in addition to what you've already mentioned:

There should be a key for each item in the v-for list in sidemenu... brought to my attention thanks to vue devtools. Not hard to implement... I think we could make the key correspond to the link name since the link names are unique.
styling adjustments to make design similar to other kokalee website

rachel-joy commented 6 years ago

Ok! I think this pr is ready to be merged into development. I'd rather start a new branch of off development once this is merged to make styling changes.

The error with the logger related code was because TS introduces a new flag in version 2.7 ... see issue and solution here ... thanks to pro tip from Emily.

I added a key to our v-for directive in sidemenu component and got rid of the unnecessary '/sidemenu' route.