search

tekgrunt / kokalee

This is the main home for the edge networking project aimed at remote teams or low-budget remote camps (aka. tent style cams).
2 stars 1 forks source link

Get CSS hooked up to the login component #8

Closed tekgrunt closed 6 years ago

tekgrunt commented 6 years ago

I am not sure if this is worth chasing down because Emily said she was going to revert the login component back to a single file pattern which is what I think the rest of the components are running with which have the default bootstrap styling being applied. Check with Emily and see what the plans are for this component and act accordingly.

rachel-joy commented 6 years ago

kokalee-login

What I've got going on on my local branch:

I figured out why those bootstrap override variables in _variables.scss weren't working and changed them so they work. I added the kokalee colours to that file as variables so we can reference them. I didn't spend a lot of time thinking about which colour should be primary, secondary, etc, as I figure that's a design question that could use other people's input. I added a scss login partial and can confirm it works. An alternative is to write the login scss styles directly in the component, but so far it looks like styles have been written in separate files in the scss folder and then referenced by a tag in the main index.html file, so I went with that method.

Right now the login component is nested in the sidemenu div which has a media query that makes the sidemenu disappear on a smaller screen.... so the login input form and button as well a the create account button disappear too.

I'm not sure what the final desired mockup is for this sidemenu and login component, so I'm not sure what else to do here! Just wanted to update you. :)

forivall commented 6 years ago

at the very least, it's more usable :D , and we have the base styling things set up. I mainly put it in the sidebar because that was an easy place to put it.

when i was first adding the login, I would have wanted to put it in the top right in the navbar, and make it appear in a dropdown or modal or a button that makes it appear in side by side, or we can modify things so that the use has to log in before they see any UI...

basically, there's lots of different UX options for login

@tekgrunt did you have any mockup ideas for login? should I make some napkin drawings and attach them?

tekgrunt commented 6 years ago

I am going to close this... I think there is more styling work to do but I want to create a clean set of issues we can work on as we count down to the demo.