tekinged / missing

The repository where the tekinged.com committee tracks and defines missing words. Anyone can join!
https://tekinged.com
Apache License 2.0
4 stars 0 forks source link

FEATURE REQUEST: Links and Tooltips in the Palauan Example Text Page #390

Closed ChrisPerrette closed 1 year ago

ChrisPerrette commented 1 year ago

Would it be too much to ask for clickable links and tooltips in the Palauan text on the Palauan Example Text page? Hopefully most of the code from the main page would be reusable.

johnbent commented 1 year ago

Should be easy. I believe that page is already created by a shared function called something like make_table_page which is also the same function which makes the word lists. I just need to modify that function to identify columns which are pal text (should be easy since database table schemas are mostly consistent) and then pass those columns to the pwords_to_plinks function.

johnbent commented 1 year ago

Nice suggestion; thanks!

johnbent commented 1 year ago

Hey @ChrisPerrette , I think I did this successfully. Can you check please and close this issue if it looks good to you?

Thanks again for this suggestion. Sorry it took me forever to get to this. Wow, it took me seven months. :(

johnbent commented 1 year ago

You might need to flush and refresh your cache. I had to do that to see changes in chrome.

ChrisPerrette commented 1 year ago

image Hey, it seems like it mostly works.