Created most of the front end for the deviations page

teknik-eksjo / chronos

A scheduling app that helps teachers submit workday outlines

MIT License

5 stars 5 forks source link

Created most of the front end for the deviations page #138

Closed shhmon closed 8 years ago

shhmon commented 8 years ago

This resulted in some fiddling with js and css files for the base-schedule page aswell. You can now add deviations and remove them. The date picker is temporary.

Greenheart commented 8 years ago

Looking and working good! :smile:

Some feedback:

[ ] I think the add- and remove-buttons need to have a bigger clickable area.
[x] I found some javascript-linting-errors. (Check diff-comments below)

Fix these things, do an interactive rebase to squash commits (git rebase -i HEAD~<number of commits>) and then push back up again

shhmon commented 8 years ago

@Greenheart I've corrected the errors. The area of the buttons didn't strike me as a milestone 0 improvement, so I won't fiddle with that just yet.

Edit: Created issue #140 for the button area question.

Limpan commented 8 years ago

Amend your latest commit and force push to your fork and the pull request will update automatically.

Greenheart commented 8 years ago

@Catagen Good job!