search

teknogods / OpenParrot

Open Source version of TeknoParrot by NTA, avail and Reaver
GNU General Public License v3.0
230 stars 47 forks source link

Added CRC's for the latest updates. #159

Closed EmuAl closed 2 years ago

EmuAl commented 2 years ago

Added CRC's for the latest updates. hopefully it's done correctly this time, using vs2019 program.

EmuAl commented 2 years ago

so it looks better this time but still failed the CI, on assembly-info stuff, is this something i need to add ?

Harmmmm commented 2 years ago

Before you commit make sure it compiles on your pc and test your changes. ;)

You didn't added the new game versions to the GameID enum and didn't add the initfunctions for it.

EmuAl commented 2 years ago

thanks again for the pointers, i've added to the GameID.h file, just need to know where to look for initfunctions thing ?

EmuAl commented 2 years ago

looking at the initfunctions items in the sln, it seems there is nothing in there to add so it must go somewhere else

EmuAl commented 2 years ago

right so in the apm3.cpp thats where the functions go ?

Harmmmm commented 2 years ago

right so in the apm3.cpp thats where the functions go ?

yes

Poliwrath commented 2 years ago

Rolling Gunner doesn't have patches, so you don't need to give the new version a special game ID. You can use either RollingGunner20 or RollingGunner21, eventually we should get rid of duplicate game IDs. (look how you added ALESTE and the other DOA6 versions for example, that's perfect)

Unfortunately, Pengo DOES have patches, so you'd have to figure out how to port them if the addresses are different.

Also, the assemblyerror warning in CI is irrelvant, you want to search for "error".

c:\projects\openparrot\openparrot\src\utility\gamedetect.cpp(688): error C2838: 'Pengoe512_Test': illegal qualified name in member declaration [C:\projects\openparrot\OpenParrot\OpenParrot.vcxproj]
c:\projects\openparrot\openparrot\src\utility\gamedetect.cpp(688): error C2065: 'Pengoe512_Test': undeclared identifier [C:\projects\openparrot\OpenParrot\OpenParrot.vcxproj]
c:\projects\openparrot\openparrot\src\utility\gamedetect.cpp(691): error C2838: 'Pengoe512': illegal qualified name in member declaration [C:\projects\openparrot\OpenParrot\OpenParrot.vcxproj]
c:\projects\openparrot\openparrot\src\utility\gamedetect.cpp(691): error C2065: 'Pengoe512': undeclared identifier [C:\projects\openparrot\OpenParrot\OpenParrot.vcxproj]
EmuAl commented 2 years ago

i think i've fixed all the errors, i've added the updates and built the files and have them working here, the only thing thats got me is the patch thing for pengo, i don't understand where or how to get the numbers that are added in the patch on original pengo i was getting errors because my user folder has a space in my name in it and the vcxproj files have no "" on the filepath entries, i had to add the "" and its seems fine, i don't know if this causes any problems for anything else.

Poliwrath commented 2 years ago

It's difficult to explain it, those are code patches (to the game). You can just remove pengo from your PR if you want.

EmuAl commented 2 years ago

yep i'll remove pengo as i don't know anything like that yet. its ok for me to combine the rolling gunner entries to be like aleste ?

Poliwrath commented 2 years ago

Yeah, that's fine.