search

teknologi-umum / blog

Blog for Teknologi Umum
https://teknologiumum.com/?utm_source=github
24 stars 25 forks source link

Refactor/dark mode #127

Closed krowter closed 1 year ago

krowter commented 1 year ago

Why this PR?;

Issue: Ini existing issue, di teknologiumum.com sekarang juga. Kalo user pilih Light Mode di toggler, tapi ada device-prefers-dark, React Giscus nya lebih milih dark wkwkwwk

netlify[bot] commented 1 year ago

Deploy Preview for teknum ready!

Name Link
Latest commit 0a623c301d2f690c3e992c8b7846642b50025343
Latest deploy log https://app.netlify.com/sites/teknum/deploys/64356d375ce0ca0008c71fab
Deploy Preview https://deploy-preview-127--teknum.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lamualfa commented 1 year ago

Sebenarnya lebih prefer pakai existing library kayak next-themes karena dia udah support no-flash pas pakai SSR/SSG atau pas ganti color modenya.

Tapi implementasi yang sekarang sudah bagus dan cukup.

Thank you @krowter.

Edit

Btw ini cara approve dari GitHub mobile gimana ya?

krowter commented 1 year ago

Approve kayaknya harus lewat tab "Files Changed" terus klik tombol hijau @lamualfa Edit: salah baca, kirain Github di browser mobile