refactor: tidy up some old code

elianiva commented 1 year ago

use pnpm instead of npm
changed indent style from 2 to 4 to make it look less cluttered
extract prop typings into its own separate type definition
dedupe type definition
remove props destructuring since it makes it less clear if a value comes from props
fix hydration mismatch when rendering caused by figure nested inside p
safer null/undefined check by enforcing the value to be boolean
added missing type annotations in some components
updated svgr config according to docs

netlify[bot] commented 1 year ago

Deploy Preview for teknum ready!

Name	Link
Latest commit	f4774205fe6a905c10de0047363ee0e52b51c968
Latest deploy log	https://app.netlify.com/sites/teknum/deploys/64a17cf3cb46bd000895bd06
Deploy Preview	https://deploy-preview-138--teknum.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aldy505 commented 1 year ago

Should bump to Node 20

aldy505 commented 1 year ago

Some issues with this PR:

GitHub actions workflow error: Invalid workflow file: .github/workflows/ci.yml#L38 The workflow is not valid. .github/workflows/ci.yml (Line: 38, Col: 20): Unexpected value '' .github/workflows/ci.yml (Line: 39, Col: 15): Unexpected value 'path'

Netlify build error: (see https://app.netlify.com/sites/teknum/deploys/648e7a802b726c00074b6a53)

10:31:54 AM: Netlify Build                                                 
10:31:54 AM: ────────────────────────────────────────────────────────────────
10:31:54 AM: 
10:31:54 AM: ❯ Version
10:31:54 AM:   @netlify/build 29.12.1
10:31:54 AM: 
10:31:54 AM: ❯ Flags
10:31:54 AM:   baseRelDir: true
10:31:54 AM:   buildId: 648e7a802b726c00074b6a51
10:31:54 AM:   deployId: 648e7a802b726c00074b6a53
10:31:54 AM: 
10:31:54 AM: ❯ Current directory
10:31:54 AM:   /opt/build/repo
10:31:54 AM: 
10:31:54 AM: ❯ Config file
10:31:54 AM:   /opt/build/repo/netlify.toml
10:31:54 AM: 
10:31:54 AM: ❯ Context
10:31:54 AM:   deploy-preview
10:31:54 AM: 
10:31:54 AM: ❯ Using Next.js Runtime - v3.9.2
10:31:54 AM: 
10:31:54 AM: ❯ Outdated plugins
10:31:54 AM:    - @netlify/plugin-nextjs@3.9.2: latest version is 4.37.4
10:31:54 AM:      To upgrade this plugin, please uninstall and re-install it from the Netlify plugins directory (https://app.netlify.com/plugins)
10:31:55 AM: 
10:31:55 AM: @netlify/plugin-nextjs (onPreBuild event)                     
10:31:55 AM: ────────────────────────────────────────────────────────────────
10:31:55 AM: 
10:31:55 AM: Using Next.js 13.4.6
10:31:55 AM: Warning: support for Next.js >=11.1.0 is experimental
10:31:55 AM: NOTE: Static HTML export Next.js projects (projects that use `next export`) do not require most of this plugin. For these sites, this plugin *only* caches builds.
10:31:55 AM: 
10:31:55 AM: (@netlify/plugin-nextjs onPreBuild completed in 9ms)
10:31:55 AM: 
10:31:55 AM: build.command from netlify.toml                               
10:31:55 AM: ────────────────────────────────────────────────────────────────
10:31:55 AM: 
10:31:55 AM: $ npm run build && npm run export
10:31:55 AM: > teknum-blog@0.1.0 build
10:31:55 AM: > next build
10:31:56 AM: - warn No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache
10:31:56 AM: - info Linting and checking validity of types...
10:31:58 AM: - info Creating an optimized production build...
10:32:10 AM: Failed to compile.
10:32:10 AM: 
10:32:10 AM: ./services/post-by-slug.ts
10:32:10 AM: Module not found: Can't resolve 'fs/promises'
10:32:10 AM: https://nextjs.org/docs/messages/module-not-found
10:32:10 AM: Import trace for requested module:
10:32:10 AM: ./services/index.ts
10:32:10 AM: ./pages/search.tsx
10:32:10 AM: ./services/post-slugs.ts
10:32:10 AM: Module not found: Can't resolve 'fs/promises'
10:32:10 AM: https://nextjs.org/docs/messages/module-not-found
10:32:10 AM: Import trace for requested module:
10:32:10 AM: ./services/index.ts
10:32:10 AM: ./pages/search.tsx
10:32:10 AM: > Build failed because of webpack errors
10:32:11 AM: 
10:32:11 AM: "build.command" failed                                        
10:32:11 AM: ────────────────────────────────────────────────────────────────
10:32:11 AM: 
10:32:11 AM:   Error message
10:32:11 AM:   Command failed with exit code 1: npm run build && npm run export (https://ntl.fyi/exit-code-1)
10:32:11 AM: 
10:32:11 AM:   Error location
10:32:11 AM:   In build.command from netlify.toml:
10:32:11 AM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
10:32:11 AM:   npm run build && npm run export
10:32:11 AM: 
10:32:11 AM:   Resolved config
10:32:11 AM:   build:
10:32:11 AM:     base: /opt/build/repo
10:32:11 AM:     command: npm run build && npm run export
10:32:11 AM:     commandOrigin: config
10:32:11 AM:     environment:
10:32:11 AM:       - REVIEW_ID
10:32:11 AM:     publish: /opt/build/repo/out
10:32:11 AM:     publishOrigin: config
10:32:11 AM:   plugins:
10:32:11 AM:     - inputs: {}
10:32:11 AM:       origin: ui
10:32:11 AM:       package: '@netlify/plugin-nextjs'
10:32:11 AM: Build failed due to a user error: Build script returned non-zero exit code: 2
10:32:11 AM: Failing build: Failed to build site
10:32:12 AM: Finished processing build request in 58.313s

aldy505 commented 1 year ago

@elianiva the build still failed

elianiva commented 1 year ago

ga ngerti apa yg salah sama netlify, di local bisa, mau cek ga punya akses netlify

aldy505 commented 1 year ago

minta akses ke @lamualfa dia yang punya akun kalo gasalah

lamualfa commented 1 year ago

@netlify/plugin-nextjs harus diupdate dulu.

elianiva commented 1 year ago

@netlify/plugin-nextjs harus diupdate dulu.

tapi kita ngga pake itu

aldy505 commented 1 year ago

might be relevant: https://github.com/vercel/next.js/discussions/34992

I don't know for sure though, I don't code in next

lamualfa commented 1 year ago

Pluginnya udah gw update tapi masih error di fs/promises.

teknologi-umum / blog