Closed sjib closed 1 month ago
Discussions and Decisions:
To clarify
@ponceta What do you think?
Same question with
This is an class diagramm based on the information from the INTERLIS files German, French and the translation made for TEKSI district heating.
Notes:
In class trench (Trace / Trasse) there is an attribut geometrie within the class plus extratrace_surface
and trace_ligne
In contradiction in structure (ouvrage / Bauwerk) the geometry attributes are only in the extra classe structure_surface
and structure_ligne
It looks like this is a modelling error in INTERLIS with class trench
I suggest to start with implementing:
[x] geometry3D as surface for classes trench and ouvrage in TEKSI Distant heating
I believe the definition of 3D is wrong in the data model ALTER TABLE tdh_od.structure ADD COLUMN geometry3d_geometry geometry('CURVEPOLYGONZ', :SRID);
CURVEPOLYGONZ is a 2D polygon made of straights and arcs with XYZ coordinates, but it is not a 3D object. in order to support a 3D volume we should use ALTER TABLE tdh_od.structure ADD COLUMN geometry3d_geometry geometry('POLYHEDRALSURFACEZ', :SRID);
CURVEPOLYGONZ is a 2D polygon made of straights and arcs with XYZ coordinates, but it is not a 3D object. in order to support a 3D volume we should use ALTER TABLE tdh_od.structure ADD COLUMN geometry3d_geometry geometry('POLYHEDRALSURFACEZ', :SRID);
We are not yet at 3D volumes with TEKSI - I think if we want to go that far we would need to discuss this in the technical group. @ponceta Can you put this on the agenda for one of the next meetings? At all: Do you see any need to change to 3D volumes in TEKSI already? Is this manageable for the day to day operation?
Please at your comments in this discussion: https://github.com/orgs/teksi/discussions/104
ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d_geometry geometry('COMPOUNDCURVEZ', :SRID); should not it be ? ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d_geometry geometry('POINTZ', :SRID);
ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d_geometry geometry('COMPOUNDCURVEZ', :SRID); should not it be ? ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d_geometry geometry('POINTZ', :SRID);
https://github.com/teksi/district_heating/pull/1/files#r1609444748
ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d_geometry geometry('COMPOUNDCURVEZ', :SRID); should not it be ? ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d_geometry geometry('POINTZ', :SRID);
Should be corrected with https://github.com/teksi/district_heating/pull/1/commits/c28066d3fe29c40a235b4c5e3cd19da22e99a8ad
Still open:
@jbl typing mistake ALTER TABLE tdh_od.pipe_point ADD COLUMN geometry3d3d_geometry geometry('POINTZ', :SRID); CREATE INDEX in_tdh_pipe_point_geometry3d_geometry ON tdh_od.pipe_point USING gist (geometry3d_geometry );
@jpdupuy Should be fixed with https://github.com/teksi/district_heating/pull/1/commits/b5f7714340e2af75305988abd26365338c288a99
Supporter n lignes - I have to add an extra table *_line for that Added with https://github.com/teksi/district_heating/pull/1/commits/43f85650dca9afdac550198379c104f1ccc84ad2
@jpdupuy This has the requirement to have the extension "uuid-ossp
" installed in the database
Maybe you can add datamodel/changelogs/0001/00_extensions.sql in your setup script for windows.
@sjib This extension has been included in our windows setup script TEKSI_CAD.zip
The SIA405 Fernwaerme Model is modelling geometries Surface and Ligne of OUVRAGE and TRACE with an extra class:
Tthis would allow to have several surfaces and lines for the classes OUVRAGE / TRACE. This would allow to have an e.g. inner and outer surface and if needed lines for drawing details.
Should this be supported in this first version of the module?
We could also just start with one each and see if this is enough during the discussion of your prototype.
Do you want support for 3D geometry?
Currently geomtries are modelled like this: 2D
3D
In TEKSI Wastewater we have changed to 3D