search

teksi / wastewater

[DEV] Future TEKSI wastewater module, adapted data model to fit VSA-DSS 2020 new standard
https://teksi.github.io/wastewater
GNU General Public License v3.0
0 stars 5 forks source link

Filtered Exports failing #154

Open cymed opened 5 months ago

cymed commented 5 months ago

Filtered Exports might be failing if they include any classes hotfixed in #153

3nids commented 5 months ago

the issue you mentioned was because the workflow was run from a fork and secrets variables are not available

cymed commented 5 months ago

The problem I am referencing is that for most classes from VSA DSS, the query filter based on self.subset_ids is not set correctly. self.subset_ids contains the wastewater_networkelement, but all queries are structures as

query = query.filter(
                self.model_classes_tww_od.retention_body.obj_id.in_(self.subset_ids)
            )

, even though they do not share an obj_id with networkelement

sjib commented 2 months ago

@cymed So how would we have to set the filters? Would we need to follow the model hierarchy?

cymed commented 2 months ago

I think we need to cascade down from the subset oids to the specific oids using joins

sjib commented 1 month ago

rohrprofil_geometrie needs to be adapted also: https://github.com/cymed/TEKSI-wastewater/blob/0c868c69f211cd1fc3f728e2c7c411656f3bbae2/plugin/teksi_wastewater/interlis/interlis_model_mapping/interlis_exporter_to_intermediate_schema.py#L1980

See adaptions on qgep in adding all classes to wastewater_networkelement into the join statement: https://github.com/QGEP/qgepqwat2ili/pull/144#issuecomment-2113369409

ponceta commented 1 month ago

sia debug port from QGEP FIX to TEKSI Wastewater