teksi / wastewater

[DEV] Future TEKSI wastewater module, adapted data model to fit VSA-DSS 2020 new standard
https://teksi.github.io/wastewater
GNU General Public License v3.0
2 stars 5 forks source link

INTERLIS Import last_modification is updated also with append #368

Open sjib opened 2 months ago

sjib commented 2 months ago

Describe the bug A clear and concise description of what the bug is.

When re-importing the same dataset e.g. organisation it shows in the wizard, that it already exists and only appends new data. (append mode).

The strange thing is, that also for the existing objects in this append mode, the last_modification field is updated.

Expected behavior A clear and concise description of what you expected to happen.

In append mode (as currently implemented) existing datas last_modification field should not be updated to the time of a re-import. This behaviour should be implemented in a update mode, when an existing dataset is really updated and e.g. an attribute is changed.

Screenshots / data If applicable, add screenshots or data to help explain your problem.

see https://github.com/teksi/wastewater/pull/367#issuecomment-2274274925

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

To be fixed with TIT project

sjib commented 2 months ago

20240806_import_export_change_of_lastmodification_xtf

If we import a dataset and re-import it the last_modification is changed. Shouldn't the last_modification of the import data (what is in the xtf) be kept? Or is importing data in another system considered a modification?

Is this a behaviour we want or not? @cymed @teksi/technical-group

cymed commented 2 months ago

I think we don't want this behaviour. I suggest the same strategy as with enabling/disabling symbology triggers