Fix several bugs on QGIS .qgs project

teksi / wastewater

[DEV] Future TEKSI wastewater module, adapted data model to fit VSA-DSS 2020 new standard

https://teksi.github.io/wastewater

GNU General Public License v3.0

2 stars 5 forks source link

Fix several bugs on QGIS .qgs project #465

Closed ponceta closed 1 month ago

ponceta commented 1 month ago

General

[x] Fix several bugs

Describe your changes

[x] Set as mandatory fk_dataowner fk_provider for reach points, wastewater structures, reaches
[x] Set rule on reach attributes to avoid rp_obj_id duplication
[ ] Removed : ~~Add reach points to the project visible from scale 1:100~~

Screenshots

Issue ticket number and link

Fix :

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.
[x] CI Tests are green
[x] The documentation is up to date with the proposed change.
[x] My work is ready for review

Checklist before merge

[ ] A review has been performed
[ ] Comments are resolved
[ ] Documentation is ready

ponceta commented 1 month ago

Cutting is working as expected if reaches have a correct 3D Geometry :

Link between reaches has to be set with the connect tool, usually a wastewater structure / wastewater node will be set on that point.

urskaufmann commented 1 month ago

This cutting is on one side a help (I have less manual work), on the other side there is a lot of things to think about when using this cut (levels, connections, also connections of other reaches to the trimmed reach (Blindanschluss)). The wish for a complete tool remains...

urskaufmann commented 1 month ago

3d geometry: As long as I can not export/import the 3d geometry, I will not enforce this 3d thing.

Vision until the ili-definition supports 3d: TEKSI exports always (user to not care about) together with the xtf a exchange-file with 3d-geometries. When importing and this exchange file exist, TEKSI imports after the xtf-part also the 3d part and updates the geometries.

cymed commented 1 month ago

General question: Why do we need the visualisation of the reach points in the project? We can access the data via vw_tww_reach.

ponceta commented 1 month ago

General question: Why do we need the visualisation of the reach points in the project? We can access the data via vw_tww_reach.

[x] Actually only for debugging purpose now. I'll draw it back from this PR so we can still add it manually when needed.

It could be nice to display visually the outlet shapes and altitudes / in the future to edit the reach start or end point.

ponceta commented 1 month ago

Reach point layer has been removed.