teksi / wastewater

[DEV] Future TEKSI wastewater module, adapted data model to fit VSA-DSS 2020 new standard
https://teksi.github.io/wastewater
GNU General Public License v3.0
2 stars 5 forks source link

last translations tww-project, german are not ok #469

Open urskaufmann opened 1 month ago

urskaufmann commented 1 month ago

Describe the bug there have been several translation in the last days (189 strings by geopint): thanks for the work. But sorry: there are too many bad translations: There should the used the DSS-Terms and not some other translations: Example: renovation_demand is Sanierungsbedarf, not Renovationsbedarf, urgency_figure is Dringlichkeitszahl, not Dringlichkeitswert. etc. And the idee of the class-shortcuts as prefix is not realized in the translation. I think it should be handled as in QGEP, where we had also these shortcuts in german (there are also defined in the TWW-Database) and in german they are with capital letters.

@PeterZamudio and Sandro: Pleace do better not translate than translate like this.

ponceta commented 1 month ago

@sjib I do think we need to set some common reference before going further on what you provided me, renovation_demand is Instandstellung...

image

Glossaries have been set today on Transifex but they do not enforce anything. (Anyone is free to uses the provided strings) We could add people as "réviseurs" to deal with specific translations.

Glossaries are not providing any hint on fk_values, relation_values (co_renovation_demand), technical values (detail_geometry3d_geometry) so we maybe have to think of that too.

You can have a look at the proposed values here : https://docs.google.com/spreadsheets/d/1qeoCVwdOLyhdLHqVKsOzZ5zyle3iiQd1pVTFKU_rbGU/edit?usp=sharing

sjib commented 1 month ago

That is a tricky one

We have

and

sjib commented 1 month ago

Here an example how to correctly translate the prefixes (shortcuts) of classes (these can be found in tww_sys.dictionary_od_table)

grafik

Example: co_venting become de_Entlueftung

grafik

sjib commented 1 month ago

Example venting (attribute) - has now the hints in the Glossary tab and the translation can be copied from there.

grafik

sjib commented 1 month ago

The layer name should not be translated (have also not been translated in qgep), as we don't know whether this would break the project.

Check for the context: project\:layers\:cover_venting

grafik

sjib commented 1 month ago

@urskaufmann Can you document which fields not to translate (was this your comment about that https://github.com/teksi/wastewater/issues/398#issuecomment-2348716692)? Could you add a screenshot of an example?

urskaufmann commented 1 month ago

Be careful about value_en. First: all value_en are at the moment translated. But there will be more "value_en" if there will be more value_lists in the project.

When translating it's important to know, where the word is coming from. In "more info" you find for every text the context. "value_en" has two contexts:

  1. it can be a value_relation value: then it has to be translated to value_de or value_fr: image green: table or view, field. blue: valuerelation value image effect: in the translated project, there will stand value_de / value_fr instead of value_en - you have your language.

  2. it can by a field alias (name of the attribute of a table or of a view). All other fieldaliases should be translated, but not field-aliases of value lists (Wertetabellen). Becaue if you do this, there will be two fields with value_de after the translation. The value relation goes to the field with name value_de. QGIS will take the first field with value_de. This is the field with the english values, but has alias value_de. Your valuelists in the attributes form will be in english! image these blue value_en should keep his name. image Do not translate field aliases of value list!.

Value lists are tables with name "classname"_"fieldname". In the example: class reach_point, field elevation_accuracy

ponceta commented 1 month ago

@urskaufmann thank you for this very precious feedback, I fixed the FR translation on that matter using this query filter :

text:value_en context:fieldaliases

image

urskaufmann commented 4 weeks ago

Most of the fieldnames, the layer names etc. are now translated in german version. @ponceta: please add the qm-file to the last version. If have not tested the whole project. But there are several things to do manually. E.g. project/preferences/variables: translate the variables tww_bottom_prefix(S), tww_cover_prefix(D), tww_output_prefix(A), tww_input_prefix(E), tww_pwwf_bigsymbols (PAA.)

I have also noted, that there are in two cases different shortcuts for tables in dict_od_tables and in the vw_tww-tables: For channel is "CL" in dictionary, but "ch" in your views (was already in QGEP like this). For biol_eco_assessment is "BO" in the dictionary, but "ba" in your views.

The download and upload worked very well and the whole history is still there (but is not in the download-file). It's seems possible to just upload some new translated strings. I have prepared the translation in a xls-file, there compining all tww_dict-strings and all qgep_strings.