teksi / wastewater

[DEV] Future TEKSI wastewater module, adapted data model to fit VSA-DSS 2020 new standard
https://teksi.github.io/wastewater
GNU General Public License v3.0
2 stars 5 forks source link

Shortcuts in dict_od_tables and as prefix for attribute-names in views #489

Open urskaufmann opened 3 weeks ago

urskaufmann commented 3 weeks ago

Describe the bug In two cases we have different shortcuts for tables in dict_od_tables and in the vw_tww-tables: For channel is "CL" in dictionary, but "ch" in your views (was already in QGEP like this). For biol_eco_assessment is "BO" in the dictionary, but "ba" in your views.

Suggestion: Change the english shortcuts in the dict_od_tables to CH and BA instead of CL and BO.

ponceta commented 2 weeks ago

@sjib has this an impact on your db init .sql scripts?

sjib commented 2 weeks ago

Yes, I have to make the changes in the creation of the dictionary tables if we want to change that.

BA is the shortcut_en for Class Badestelle (in qgep), so we should not change that to stay with unique shortcuts per language.

CL -> CH for Channel would be possible.

@ponceta How much effort is it to change the view?

I suggest a general principle (to be integrated in the Developers guides): Views should be developed based on the sys dictionaries on not the other way round else we loose control over used shortcuts

ponceta commented 2 weeks ago

This should be no big deal to adapt views in consequence. Better do it before any official release is published.

sjib commented 1 week ago

@urskaufmann @ponceta ok like this? If yes I will make a patch for qgep also

sjib commented 1 week ago
ponceta commented 1 week ago

Were are these official shortcut defined (except in the code of dictionary tables)