not able to change maintenance_type

[urskaufmann]

I get these error when editing data from vsa_version 2015: WARNING Fehlerhafte Abfrage: UPDATE "tww_app"."vw_tww_maintenance_event" SET "maintenance_event_type"='examination' WHERE "obj_id"::text='ch080qwzEH001128' ergab 7 [ERROR: Type change not allowed for maintenance_event HINT: You cannot switch from unknown to examination CONTEXT: PL/pgSQL function tww_app.ft_vw_tww_maintenance_event_update() line 26 at RAISE

I agree it should not be possible (without further UI) to change the type, after it is set. But I think it should be possible to change once from "unknown" to one of the other types. "Unknown" is not a "type" (not a subclass of maintenance_event).

[3nids]

Is it allowed to have a maintenance_event without a type ? (i.e. is it abstract or not)

[sjib]

There was a change from 2015 to 2020: maintenance_event is in release 2020 ABSTRACT, before it was not.

[urskaufmann]

if I import the VSA-Musterdatensatz, I get type=unkown and I'm not able to correct this... What does the VSA-Checker convert2020 with old maintenance_event records?

[3nids]

So, this is not a problem of the data model but:

• the data
• pirogue (the tool which creates the view): if no type is set, it writes "unknown", but then we are not allowing type change

We can discuss if we want to fix/adapt pirogue for this.

[cymed]

It also does not allow manually inserting a row, as it is set to "unknown" as a default and then does not allow changing that value

[sjib]

May be we should change the default to maintenance instead and take out the option unknown, as unknown just seems to create problems.

[sjib]

@urskaufmann with my last import I did not have problems.

Maybe we first re-check before we further go with this.

[sjib]

We still are missing the data in the tww_od.re_maintenance_event_wastewater_structure table after import. see https://github.com/teksi/wastewater/issues/352