Closed dhaus67 closed 5 months ago
Hi @dhaus67. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/kind feature
/verify-owners
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign vdemeester
/verify-owners
/verify-owners
/test pull-catalog-catlin-lint
@vinamra28: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests
Use /test all
to run all jobs.
can you please squash the commits? will merge post that
/lgtm
Changes
Add a new task which handles authentication for RHACS tasks (i.e.
rhacs-image-scan, rhacs-image-check, rhacs-deployment-check
).The task will allow folks to make use of projected volumes for obtaining a valid RHACS token instead of relying on long-living API tokens as before.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep[x] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
<kind>/<name>/<version>/name.yaml
README.md
at<kind>/<name>/<version>/README.md
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourcemetadata.annotations
tekton.dev/pipelines.minVersion
[x] mandatory
spec.description
follows the conventionSee the contribution guide for more details.