tektoncd / catalog

Catalog of shared Tasks and Pipelines.
Apache License 2.0
666 stars 577 forks source link

Update RHACS image scan version to 0.1/0.2. #1271

Closed dhaus67 closed 4 months ago

dhaus67 commented 5 months ago

Changes

As discussed within Slack, updating the version of the task to be according to guidelines.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

tekton-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign bobcatfish after the PR has been reviewed. You can assign the PR to them by writing /assign @bobcatfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/catalog/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dhaus67 commented 5 months ago

/kind feature

tekton-robot commented 5 months ago
Catlin Output ``` FILE: task/rhacs-image-scan/0.1/rhacs-image-scan.yaml WARN : Step "rox-image-scan" uses image "$(params.rox_image)" that contains variables; skipping validation FILE: task/rhacs-image-scan/0.2/rhacs-image-scan.yaml ```
vdemeester commented 5 months ago

Given that it is already indexed by artifactub, I wonder if that's worth changing now (as artifacthub might keep showing the "non-reachable" 4.0.0 release)

2024-06-10-121527

dhaus67 commented 5 months ago

@vdemeester The main point why we wanted to make the version change was to be able to browse those tasks while using e.g. the OpenShift pipelines operator. Currently the tasks do not show up, and also while browsing https://hub.tekton.dev they also do not show up.

tekton-robot commented 5 months ago

@dhaus67: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dhaus67 commented 4 months ago

Not required anymore, as the Hub has been updated to display v1 Tasks.