tektoncd / catalog

Catalog of shared Tasks and Pipelines.
Apache License 2.0
662 stars 576 forks source link

ISSUE-1289: Superfluous 'output' workspace defined in git-cli env #1291

Closed anilabhabaral closed 2 months ago

anilabhabaral commented 2 months ago

Changes

Fix for #1289

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

tekton-robot commented 2 months ago

Hi @anilabhabaral. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 2 months ago
Catlin Output ``` FILE: task/git-cli/0.4/git-cli.yaml WARN : Step "git" uses image "$(params.BASE_IMAGE)" that contains variables; skipping validation ```
anilabhabaral commented 2 months ago

/assign @vinamra28

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/catalog/blob/main/OWNERS)~~ [vinamra28] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment