tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
240 stars 125 forks source link

Expose performance options #1079

Closed lcarva closed 4 months ago

lcarva commented 4 months ago

Changes

This allow users to specify the number of concurrent threads the Chains controller processes. The default value is 2 which is not realistic for large deployments.

The approach taken here is the same one used by the Tekton Pipeline controller for the sake of consistency in the ecosystem.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Expose new performance parameters to control controller's execution. See docs at https://tekton.dev/docs/chains/performance for details.
tekton-robot commented 4 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 4 months ago

@vdemeester: cat image

In response to [this](https://github.com/tektoncd/chains/pull/1079#pullrequestreview-1946489844): >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/chains/blob/main/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vdemeester commented 4 months ago

@chitrangpatel @lcarva can we also backport this to a few previous release ? 🙏🏼

chitrangpatel commented 4 months ago

/lgtm