tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
240 stars 125 forks source link

Expose performance options (v0.16) #1080

Closed lcarva closed 4 months ago

lcarva commented 4 months ago

Changes

This allow admins to specify a few parameters to better suit their use of Chains.

--threads-per-controller controls the number of concurrent threads the Chains controller processes. The default value is 2.

--kube-api-burst controle the maximum burst for throttle.

--kube-api-qps controles the maximum QPS to the server from the client.

The approach taken here is the same one used by the Tekton Pipeline controller for the sake of consistency in the ecosystem.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Expose new performance parameters to control controller's execution. See docs at https://tekton.dev/docs/chains/performance for details.
chitrangpatel commented 4 months ago

/approve /lgtm

lcarva commented 4 months ago

/approve

tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/chains/blob/release-v0.16.x/OWNERS)~~ [lcarva] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment