tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
246 stars 129 forks source link

Currently tektoncd/chains uses `Deprecated` in-toto/in-toto-golang `Subject`, `StatementHeader`, etc. structs. #1087

Closed aaron-prindle closed 3 months ago

aaron-prindle commented 6 months ago

Currently tektoncd/chains uses deprecated https://github.com/in-toto/in-toto-golang structs:

https://github.com/in-toto/in-toto-golang/commit/32351740df5f3e9c079d4fe12bcf27271e2290b1

https://github.com/in-toto/in-toto-golang/blob/master/in_toto/attestations.go#L32-L42

We should update tektoncd/chains code to use the correct structs

Possibly related: https://github.com/tektoncd/chains/issues/920

renzodavid9 commented 3 months ago

With the work we did in https://github.com/tektoncd/chains/pull/1111 and https://github.com/tektoncd/chains/pull/1118, we migrated the structs to the non-deprecated versions. I think it should be fine to close this issue @chitrangpatel

chitrangpatel commented 3 months ago

agreed!