tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
240 stars 125 forks source link

Move external paramenters and resolved dependencies logic out of v2alpha3 #1109

Closed renzodavid9 closed 2 months ago

renzodavid9 commented 2 months ago

Related with: #1065

This is a refactor in preparation for v2alpha4 which uses in its majority the same logic as v2alpha3.

Logic and tests moved to chains/formats/slsa/internal to be able to use it from different versions:

Current behavior shouldn't change with these changes.

This refactor will be use as base to enable v2alpha4 for TaskRuns, diff can be preview here

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

tekton-robot commented 2 months ago

Hi @renzodavid9. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chitrangpatel commented 2 months ago

/ok-to-test

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/external_parameters/external_parameters.go 100.0% 87.5% -12.5
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 60.0% 87.5% 27.5
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 60.0% 87.5% 27.5
tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/chains/blob/main/OWNERS)~~ [chitrangpatel,lcarva] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 60.0% 87.6% 27.6
chitrangpatel commented 2 months ago

Thanks @renzodavid9! If there are still nits that need to be resolved, we can do that in the next PR. Let's unblock your work. /lgtm

chitrangpatel commented 2 months ago

/retest