search

tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
240 stars 125 forks source link

PipelineRuns with v2alpha4 to process StepActions #1118

Closed renzodavid9 closed 1 month ago

renzodavid9 commented 1 month ago

This new version will now process the information from any associated StepAction from the executed PipelineRun.

Also, the way chains read results from PipelineRuns to populate the subjects field is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the new isBuildArtifact property in the value.

Refactors to share logic between v2alph3 and v2alpha4.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

New v2alpha4 formatter for PipelineRuns that reads type-hinted result from associated StepActions
tekton-robot commented 1 month ago

Hi @renzodavid9. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 74.2% 3.6
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 65.8% 3.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 84.6%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 85.7% -1.9
pkg/chains/formats/slsa/internal/results/results.go Do not exist 88.9%
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 81.2% -2.5
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 59.3%
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 75.0%
pkg/chains/objects/objects.go 32.7% 23.9% -8.8
renzodavid9 commented 1 month ago

/retest

tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/build_definition/build_definition.go 80.0% 77.8% -2.2
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.9% 85.7% -2.2
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 78.5% 81.2% 2.8
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 59.3%
pkg/chains/formats/slsa/v2alpha4/slsav2.go 85.7% 75.0% -10.7
pkg/chains/objects/objects.go 25.6% 23.9% -1.7
chitrangpatel commented 1 month ago

Please fix the linter errors and add a release note.

tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/build_definition/build_definition.go 80.0% 77.8% -2.2
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.9% 85.7% -2.2
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 78.5% 81.2% 2.8
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 59.3%
pkg/chains/formats/slsa/v2alpha4/slsav2.go 85.7% 75.0% -10.7
pkg/chains/objects/objects.go 25.6% 23.8% -1.8
tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/build_definition/build_definition.go 80.0% 77.8% -2.2
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.9% 85.7% -2.2
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 78.5% 81.2% 2.8
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 59.3%
pkg/chains/formats/slsa/v2alpha4/slsav2.go 85.7% 75.0% -10.7
pkg/chains/objects/objects.go 25.6% 23.8% -1.8
tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/internal/build_definition/build_definition.go 80.0% 77.8% -2.2
pkg/chains/formats/slsa/internal/provenance/provenance.go 0.0% 76.9% 76.9
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.9% 85.7% -2.2
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 78.5% 81.2% 2.8
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 59.3%
pkg/chains/formats/slsa/v2alpha4/slsav2.go 85.7% 75.0% -10.7
pkg/chains/objects/objects.go 25.6% 23.8% -1.8
tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 73.9% 73.4% -0.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go 80.0% 77.8% -2.2
pkg/chains/formats/slsa/internal/provenance/provenance.go 0.0% 76.9% 76.9
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.9% 85.7% -2.2
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 78.5% 81.2% 2.8
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 84.6%
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go 80.0% 86.7% 6.7
pkg/chains/formats/slsa/v2alpha4/slsav2.go 85.7% 75.0% -10.7
pkg/chains/objects/objects.go 25.6% 24.3% -1.3
chitrangpatel commented 1 month ago

Thanks for the cleanup Renzo!

Happy to approve after fixing the linter error.

tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 73.9% 73.4% -0.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go 80.0% 77.8% -2.2
pkg/chains/formats/slsa/internal/provenance/provenance.go 0.0% 76.9% 76.9
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.9% 85.7% -2.2
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 78.5% 81.2% 2.8
pkg/chains/formats/slsa/v2alpha4/internal/pipelinerun/pipelinerun.go Do not exist 84.6%
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go 80.0% 86.7% 6.7
pkg/chains/formats/slsa/v2alpha4/slsav2.go 85.7% 75.0% -10.7
pkg/chains/objects/objects.go 25.6% 24.3% -1.3
chitrangpatel commented 1 month ago

/lgtm

tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/chains/blob/main/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chitrangpatel commented 1 month ago

/retest