tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
240 stars 125 forks source link

Fix no repeated subjects for v2alpha4 pipelineruns #1130

Closed renzodavid9 closed 1 month ago

renzodavid9 commented 1 month ago

Fixes: #1131

Change the pipelinerun v2alpha4 method that calculates the subjects to use artifact.AppendSubjects instead of append to avoid duplicated subjects.

Changes

Use of artifact.AppendSubjects instead of append when calculating subjects with artifacts.pipelinerun.enable-deep-inspection: "true" for a pipelinerun using v2alpha4 formatter.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

tekton-robot commented 1 month ago

Hi @renzodavid9. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chitrangpatel commented 1 month ago

/ok-to-test

chitrangpatel commented 1 month ago

Thanks for the quick fix @renzodavid9 !! /approve /lgtm

tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/chains/blob/main/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
renzodavid9 commented 1 month ago

Rebased with latest changes fixing t _type and predicateTpe fields, those should fix failing integration tests here

chitrangpatel commented 1 month ago

/lgtm

chitrangpatel commented 1 month ago

/kind bug