Closed renzodavid9 closed 1 month ago
Hi @renzodavid9. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Thanks for the quick fix @renzodavid9 !! /approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chitrangpatel
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Rebased with latest changes fixing t _type
and predicateTpe
fields, those should fix failing integration tests here
/lgtm
/kind bug
Fixes: #1131
Change the pipelinerun v2alpha4 method that calculates the subjects to use
artifact.AppendSubjects
instead ofappend
to avoid duplicated subjects.Changes
Use of
artifact.AppendSubjects
instead ofappend
when calculating subjects withartifacts.pipelinerun.enable-deep-inspection: "true"
for a pipelinerun using v2alpha4 formatter.Submitter Checklist
As the author of this PR, please check off the items in this checklist: