tektoncd / chains

Supply Chain Security in Tekton Pipelines

Apache License 2.0

240 stars 125 forks source link

Fixes for v0.21.1 #1134

Closed renzodavid9 closed 4 weeks ago

renzodavid9 commented 4 weeks ago

Changes

Cherry-pick fixes for v0.21.1:

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

tekton-robot commented 4 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

renzodavid9 commented 4 weeks ago

/test all

tekton-robot commented 4 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/formats/format.go	16.7%	20.0%	3.3
pkg/chains/formats/format.go	Do not exist	60.0%
pkg/chains/formats/format.go	Do not exist	13.3%
pkg/chains/formats/format.go	Do not exist	20.0%
pkg/chains/formats/format.go	Do not exist	33.3%
pkg/chains/formats/format.go	Do not exist	16.7%

renzodavid9 commented 4 weeks ago

/retest

tekton-robot commented 4 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/formats/format.go	16.7%	33.3%	16.7
pkg/chains/formats/format.go	Do not exist	0.0%
pkg/chains/formats/format.go	Do not exist	16.7%
pkg/chains/formats/format.go	Do not exist	60.0%
pkg/chains/formats/format.go	Do not exist	20.0%
pkg/chains/formats/format.go	Do not exist	20.0%
pkg/chains/formats/format.go	Do not exist	20.0%

chitrangpatel commented 4 weeks ago

/retest

chitrangpatel commented 4 weeks ago

/retest

tekton-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/chains/blob/release-v0.21.x/OWNERS)~~ [chitrangpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment