tektoncd / chains

Supply Chain Security in Tekton Pipelines

Apache License 2.0

240 stars 125 forks source link

Include the ServiceAccount running a pipeline in the chains provenance #1139

Closed jkhelil closed 2 weeks ago

jkhelil commented 3 weeks ago

Changes

Include the ServiceAccount running a pipeline in the chains provenance fixes https://github.com/tektoncd/chains/issues/1098

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Include the ServiceAccount running a pipeline in the chains provenance

jkhelil commented 3 weeks ago

/test pull-tekton-chains-integration-tests

jkhelil commented 3 weeks ago

/test pull-tekton-chains-integration-tests

PuneetPunamiya commented 3 weeks ago

LGTM

chitrangpatel commented 3 weeks ago

/lgtm

chitrangpatel commented 3 weeks ago

/remove-approve

tekton-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chitrangpatel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/chains/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

chitrangpatel commented 3 weeks ago

/remove approve

tekton-robot commented 2 weeks ago

New changes are detected. LGTM label has been removed.

chitrangpatel commented 2 weeks ago

/retest

jkhelil commented 2 weeks ago

/retest

jkhelil commented 2 weeks ago

/test pull-tekton-chains-integration-tests

tekton-robot commented 2 weeks ago

@jkhelil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-chains-integration-tests	d1e61b9a914e164cf5a8df3107acb1098586c2e8	link	true	`/test pull-tekton-chains-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).