tektoncd / chains

Supply Chain Security in Tekton Pipelines
Apache License 2.0
240 stars 125 forks source link

Support multinamespace informer filtering #1148

Open jkhelil opened 1 week ago

jkhelil commented 1 week ago

Changes

Support of specifying a list of namespaces to restrict the informer. You can provide a list of namespaces as an argument to the controller, and it will only watch objects (PipelineRuns and TaskRuns) within these specified namespaces. If no list is provided, the controller will default to watching all namespaces.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

The Chains controller now supports specifying a list of namespaces to restrict the informer. 
You can provide a list of namespaces as an argument to the controller, and it will only watch objects (PipelineRuns and TaskRuns) within these specified namespaces. 
If no list is provided, the controller will default to watching all namespaces.
tekton-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign priyawadhwa after the PR has been reviewed. You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/chains/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 0.0%
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 2.6%
pkg/reconciler/filter.go Do not exist 3.8%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 1.3%
pkg/reconciler/filter.go Do not exist 7.7%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 2.6%
pkg/reconciler/filter.go Do not exist 3.8%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 1 week ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 4 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
tekton-robot commented 4 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
tekton-robot commented 4 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/filter.go Do not exist 100.0%
pkg/reconciler/pipelinerun/controller.go 86.4% 87.0% 0.6
pkg/reconciler/taskrun/controller.go 88.9% 89.5% 0.6
PuneetPunamiya commented 2 hours ago

/test pull-tekton-chains-integration-tests

tekton-robot commented 1 hour ago

@jkhelil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-chains-integration-tests 44b4ca58280b3eeb3d0bfcfe148aa691b32253c3 link true /test pull-tekton-chains-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).