tektoncd / cli

A CLI for interacting with Tekton!
Apache License 2.0
431 stars 250 forks source link

Start task/pipeline with optional workspace does not work properly #1290

Closed lstocchi closed 3 years ago

lstocchi commented 3 years ago

Versions and Operating System

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:20:10Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18+", GitVersion:"v1.18.3+6c42de8", GitCommit:"6c42de8", GitTreeState:"clean", BuildDate:"2020-09-04T14:16:02Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
 ./tkn version
Client version: 0.15.0
Pipeline version: v0.20.1
Triggers version: v0.8.1
Fedora

Expected Behavior

Being able to start a task/pipeline that has an optional workspace without specifying the workspace. If the task has 2 params and 1 workspace (optional) as inputs i should be able to start the task by only passing the two params values

Actual Behavior

Even if my task has a workspace which is optional, the cli keeps asking me to add it when i try to start the task image

Steps to Reproduce the Problem

  1. Have a task/pipeline with a param and an optional workspace
  2. Try to start the task by only passing it the param value

Additional Info

I faced this error while working on the IJ Tekton plugin. Let me know if there is a way to bypass it. Do we need to feed the cli somehow?

tekton-robot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vinamra28 commented 3 years ago

/remove-lifecycle stale

vinamra28 commented 3 years ago

resolved in https://github.com/tektoncd/cli/pull/1377 /close

tekton-robot commented 3 years ago

@vinamra28: Closing this issue.

In response to [this](https://github.com/tektoncd/cli/issues/1290#issuecomment-856713935): >resolved in https://github.com/tektoncd/cli/pull/1377 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.