Open jkandasa opened 1 year ago
tkn version: 0.30.1
keep and keep-since support is introduced in https://github.com/tektoncd/cli/pull/1533 though, when we supply keep and keep-since simultaneously the out come always equivalent to keep, keep-since ignored
keep
keep-since
Pipelinerun: https://github.com/tektoncd/cli/blob/f4d092c77d359a48dfdecf708f72293ebf872f5a/pkg/cmd/pipelinerun/delete.go#L329-L338
taskrun: https://github.com/tektoncd/cli/blob/f4d092c77d359a48dfdecf708f72293ebf872f5a/pkg/cmd/taskrun/delete.go#L379-L388
tkn taskrun delete --keep=5 --keep-since=30
taskruns
count <= 5
start-time <= 30 minutes
pipelineruns
/assign
@pratap0007 have you started working on this issue? if not shall I take this one?
tkn version: 0.30.1
keep
andkeep-since
support is introduced in https://github.com/tektoncd/cli/pull/1533 though, when we supplykeep
andkeep-since
simultaneously the out come always equivalent tokeep
,keep-since
ignoredPipelinerun: https://github.com/tektoncd/cli/blob/f4d092c77d359a48dfdecf708f72293ebf872f5a/pkg/cmd/pipelinerun/delete.go#L329-L338
taskrun: https://github.com/tektoncd/cli/blob/f4d092c77d359a48dfdecf708f72293ebf872f5a/pkg/cmd/taskrun/delete.go#L379-L388
Expected behavior
tkn taskrun delete --keep=5 --keep-since=30
taskruns
will be ascount <= 5
andstart-time <= 30 minutes
pipelineruns
too