tektoncd / cli

A CLI for interacting with Tekton!
Apache License 2.0
426 stars 246 forks source link

issue with keep and keep-since in taskrun and in pipelinerun #1990

Open jkandasa opened 1 year ago

jkandasa commented 1 year ago

tkn version: 0.30.1

keep and keep-since support is introduced in https://github.com/tektoncd/cli/pull/1533 though, when we supply keep and keep-since simultaneously the out come always equivalent to keep, keep-since ignored

Pipelinerun: https://github.com/tektoncd/cli/blob/f4d092c77d359a48dfdecf708f72293ebf872f5a/pkg/cmd/pipelinerun/delete.go#L329-L338

taskrun: https://github.com/tektoncd/cli/blob/f4d092c77d359a48dfdecf708f72293ebf872f5a/pkg/cmd/taskrun/delete.go#L379-L388

Expected behavior

pratap0007 commented 1 year ago

/assign

jkandasa commented 1 year ago

@pratap0007 have you started working on this issue? if not shall I take this one?