tektoncd / cli

A CLI for interacting with Tekton!

Apache License 2.0

431 stars 250 forks source link

refactor export function and add finalizers to be removed #2427

Closed chmouel closed 3 weeks ago

chmouel commented 3 weeks ago

Refactor the RemoveFieldForExport function to improve readability and maintainability.

add finalizers to be removed from the metadata and spec fields

Grouped metadata and spec fields into slices and used loops to remove them. Added unit tests to verify the functionality.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Includes tests (if functionality changed/added)
[ ] Run the code checkers with make check
[ ] Regenerate the manpages, docs and go formatting with make generated
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

tekton-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/cli/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment