search

tektoncd / community

Community documentation for the Tekton project
https://tekton.dev
Apache License 2.0
360 stars 221 forks source link

[TEP-0144] Param Subset Enforcement #1106

Closed QuanZhang-William closed 8 months ago

QuanZhang-William commented 8 months ago

Prior to this commit, Tekton validates the intersection of the enums that are both specified at Pipeline level and at the referenced PipelineTask level. In this solution, users are burdened with calculating intersections by iterating through all the PipelineTasks.

This commits add an extra validation to require that the pipeline-level enum must be a subset of the corresponding pipeline-task level enum. With this approach, users only need to check the pipeline-level enum to execute the pipeline successfully.

/kind tep

QuanZhang-William commented 8 months ago

/cc @jerop. This is the preview for the TEP update.

QuanZhang-William commented 8 months ago

@QuanZhang-William thanks for the quick turnaround -- please move the existing approach to the alternatives with an explanation for why we chose another path, just so that we have a record for future reference

Thanks, Jerop! Alternatives added.

tekton-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[teps/OWNERS](https://github.com/tektoncd/community/blob/main/teps/OWNERS)~~ [afrittoli,jerop,vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
afrittoli commented 8 months ago

As discussed in the API WG, this already has enough approvals, so merging it. /lgtm